-
Notifications
You must be signed in to change notification settings - Fork 78
fix(FR-1602): update CodeMirror language option from 'shell' to 'sh' #4448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the syntax highlighting in the shell script editor by updating the CodeMirror language identifier from "shell" to "sh" in the ShellScriptEditModal component.
Key Changes:
- Updated the language prop value in the
BAICodeEditorcomponent from "shell" to "sh"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.65% | 532/11432 |
| 🔴 | Branches | 3.76% | 302/8030 |
| 🔴 | Functions | 2.88% | 102/3544 |
| 🔴 | Lines | 4.6% | 514/11172 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from a88878b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change default language of BAICodeEditor too.
e76f61e to
40edb21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
…4448) resolves #4447 (FR-1602) This PR changes the language identifier in the `ShellScriptEditModal` component from "shell" to "sh" for the code editor. This ensures proper syntax highlighting when editing shell scripts in the UI. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
40edb21 to
a88878b
Compare

resolves #4447 (FR-1602)
This PR changes the language identifier in the
ShellScriptEditModalcomponent from "shell" to "sh" for the code editor. This ensures proper syntax highlighting when editing shell scripts in the UI.Checklist: